Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Status code on validation fail

See original GitHub issue

Hello, I found such bug in returned status code when using Apollo (even in the example in this repository).

If some validation failed Apollo return status 500. I would say status code should be 400 because it is client error, not server error.

I was digging a little bit deeper. In my opinion the problem is, that you are throwing GraphQlError in error cases. But in all examples from graphql recommended in Apollo docs, they are calling ValidationContext.reportError(new GraphQlError(...) instead.

I can make pull request and we can discuss it more then.

Issue Analytics

State:
Created a year ago
Reactions:2
Comments:9 (6 by maintainers)

Top GitHub Comments

1reaction

c3b5awcommented, Sep 30, 2022

Hello, I see that it was merged already. Everything is working just fine, just one small issue. I have to install @escape.tech/graphql-armor-types separately. Otherwise typescript control fail on Cannot find module '@escape.tech/graphql-armor-types' or its corresponding type declarations.

Great catch, pushing a patch version!

1reaction

c3b5awcommented, Sep 27, 2022

#162, should introduce ability to override the error behavior.

The trade-off and how-to must be documented as well.

@PatizonP I will let you know as soon as this is done.