guard-for-in is unable to detect if statement guarding for...in loop

Tell us about your environment

• ESLint Version: 5.16.0
• Node Version: 10.16.0
• npm Version: 6.9.0 What parser (default, Babel-ESLint, etc.) are you using?

Please show your full configuration:

Configuration

module.exports = {
  env: {
    browser: true,
    es6: true,
  },
  extends: [
    'airbnb-base',
  ],
  globals: {
    Atomics: 'readonly',
    SharedArrayBuffer: 'readonly',
  },
  parserOptions: {
    ecmaVersion: 2018,
    sourceType: 'module',
  },
  rules: {
    'no-continue': 0,
    'no-plusplus': 0,
    'no-unused-expressions': [
      2,
      {
        'allowShortCircuit': true, // 允许 短路求值
        'allowTernary': true // 允许 三目运算符
      }
    ]
  },
};

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

class FormValidator extends Schema {
  constructor(formEl, rule, cb) {
    const r = { ...defaultRule, ...rule };
    super(r);

    cb && (this.cb = cb);

    const form = document.querySelector(formEl);
    formItems = form.querySelectorAll('[data-prop]');
    // 绑定事件
    for (const field in r) {
      if (!Object.prototype.hasOwnProperty.call(r, field)) continue;
      let rules = r[field];
      rules = rules instanceof Array ? rules : [rules];
      const triggerRules = rules.filter(item => {
        return item.trigger !== void 0;
      });
      if (triggerRules.length === 0) continue;
      for (let i = 0, len = triggerRules.length; i < len; i++) {
        const tr = triggerRules[i];
        const curEl = [...formItems].find(item => {
          return item.dataset.prop === field;
        });
        curEl.addEventListener(tr.trigger, ev => {
          const { value } = ev.target;
          const model = {
            [field]: value,
          };
          let s = new Schema({
            [field]: tr,
          });
          s.validate(model, (err, fields) => {
            this.finalCallback(err, fields);
          });
          s = null;
        });
      }
    }
  }
}

eslint

What did you expect to happen?

No error

What actually happened? Please include the actual, raw output from ESLint. for…in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array

Are you willing to submit a pull request to fix this bug?

[Yangfan2016]

thx, It works @kaicataldo

[kaicataldo]

Here it is. If you believe there is a bug in the rule, feel free to make an issue on that repo. That being said, it looks like the intention here is to not allow that syntax at all, so I believe it’s working correctly.