[Bug] No Fix for `sort-imports` ?

Tell us about your environment

• ESLint Version: v5.16.10
• Node Version: v11.13.0
• npm Version: v6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

Please show your full configuration:

Configuration

module.exports = {
  parser: '@typescript-eslint/parser',
  extends: [
    'plugin:react/recommended',
    // 'plugin:@typescript-eslint/recommended',
    'prettier/@typescript-eslint',
    'plugin:prettier/recommended',
  ],
  parserOptions: {
    sourceType: 'module',
    ecmaVersion: 2019,
    ecmaFeatures: {
      jsx: true,
    },
  },
  rules: {
    '@typescript-eslint/arrow-parens': [true],
    '@typescript-eslint/await-promise': [true],
    '@typescript-eslint/max-classes-per-file': false,
    '@typescript-eslint/no-console': [false],
    '@typescript-eslint/no-floating-promises': [true],
    '@typescript-eslint/object-literal-key-quotes': [false],
    '@typescript-eslint/object-literal-sort-keys': [false],
    '@typescript-eslint/ordered-imports': [false],
    '@typescript-eslint/quotemark': [true, 'single', 'avoid-escape'],
    '@typescript-eslint/semicolon': [true, 'never'],
    '@typescript-eslint/trailing-comma': [true],
    'jsx-quotes': ['error', 'prefer-single'],
    'sort-imports': [
      'error',
      {
        ignoreCase: false,
        ignoreDeclarationSort: false,
        ignoreMemberSort: false,
        memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
      },
    ],
  },
  settings: {
    react: {
      version: 'detect',
    },
  },
}

What did you expect to happen? imports to be sorted with --fix

What actually happened? Please include the actual, raw output from ESLint. Not that.

Are you willing to submit a pull request to fix this bug? No.

[ljharb]

@Industrial it’s not always. Polyfills and shims are supposed to cause side effects and be written in that way.

However, typically the only imports with side effects are ones without a binding - just like it’s safe to reorganize properties as long as nothing crosses a spread, it’s safe to sort imports as long as nothing crosses a bindingless import.

[Industrial]

The imported modules can have toplevel side effects, and rearranging the imports will then run them in different order, which could potentially break stuff.

@lydell

That should be a code smell. An indicator for people to not write their code in this way. I don’t think it should be a problem to be prevented by not implementing the sorting :S