question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

docs: Hardcode eslintVersion.js on release

See original GitHub issue

Problem

Right now, docs/_data/eslintVersion.js reads from the root package.json to retrieve the version of ESLint. This makes it difficult to copy the docs files into another repo (for translation purposes).

Solution

Instead of reading the version dynamically, we should instead just hardcode this value whenever we do a release. So in Makefile.js, we can add a step where we write the equivalent of module.exports = "8.22.0"; into docs/_data/eslintVersion.js. I think we can make that change around this line. We are already adding the contents of docs into the commit, so as long as we update eslintVersion.js before that point, everything should work.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:14 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
nzakascommented, Aug 17, 2022

I’m trying to eliminate the relationship between the docs site and the package.json. The docs site should know what version it represents without any external references.

0reactions
sararita28commented, Sep 3, 2022

I read the file changes and it seems like jugalthakkar met the latest requirements of nzakas in the PR. Any other good first issues to work on nzakas? I would love to contribute.

Read more comments on GitHub >

github_iconTop Results From Across the Web

docs: copy & use main package version in docs on release by ...
Update eslintVersion.js so that it reads from the package.json file in the docs/ directory instead of the one in the root directory. Otherwise,...
Read more >
Migrating to v3.0.0 - ESLint - Pluggable JavaScript Linter
ESLint v3.0.0 is the third major version release. We have made several breaking changes in this release, however, we believe the changes to...
Read more >
Getting Started with ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
ESLint v8.25.0 released - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
Rules - ESLint - Pluggable JavaScript Linter
Selecting a version will take you to the chosen version of the ESLint docs. Version. HEAD, v8.30.0.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found