docs: Hardcode eslintVersion.js on release
See original GitHub issueProblem
Right now, docs/_data/eslintVersion.js
reads from the root package.json
to retrieve the version of ESLint. This makes it difficult to copy the docs files into another repo (for translation purposes).
Solution
Instead of reading the version dynamically, we should instead just hardcode this value whenever we do a release. So in Makefile.js
, we can add a step where we write the equivalent of module.exports = "8.22.0";
into docs/_data/eslintVersion.js
. I think we can make that change around this line. We are already adding the contents of docs
into the commit, so as long as we update eslintVersion.js
before that point, everything should work.
Issue Analytics
- State:
- Created a year ago
- Comments:14 (9 by maintainers)
Top Results From Across the Web
docs: copy & use main package version in docs on release by ...
Update eslintVersion.js so that it reads from the package.json file in the docs/ directory instead of the one in the root directory. Otherwise,...
Read more >Migrating to v3.0.0 - ESLint - Pluggable JavaScript Linter
ESLint v3.0.0 is the third major version release. We have made several breaking changes in this release, however, we believe the changes to...
Read more >Getting Started with ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >ESLint v8.25.0 released - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >Rules - ESLint - Pluggable JavaScript Linter
Selecting a version will take you to the chosen version of the ESLint docs. Version. HEAD, v8.30.0.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I’m trying to eliminate the relationship between the docs site and the package.json. The docs site should know what version it represents without any external references.
I read the file changes and it seems like jugalthakkar met the latest requirements of nzakas in the PR. Any other good first issues to work on nzakas? I would love to contribute.