Rule Change: Treat class / instance fields as named constants in no-magic-numbers

What rule do you want to change?

no-magic-numbers

What change to do you want to make?

Generate fewer warnings

How do you think the change should be implemented?

A new default behavior

Example code

class Foo {
  static bar = 1;
  baz = 2;
}

What does the rule currently do for this code?

Shows these two errors: No magic number: 1 No magic number: 2

What will the rule do after it’s changed?

Show no errors.

Participation

• I am willing to submit a pull request to implement this change.

Additional comments

No response

[mdjermanovic]

I’ll champion this.

I think the best solution is to add a new option: ignoreClassFieldInitialValues (default false to keep the current default behavior).

[ljharb]

I think that it makes sense that detectObjects applies to assignments - but declarative things like class fields have a name, and aren’t being dynamically assigned, so i’d expect them to be accepted by default.