.eslintignore: can't exclude files from node_modules once ignored

Tell us about your environment

• ESLint Version: 4.4.1
• Node Version: 8.2.1
• npm Version: 5.3.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

module.exports = {
  extends: 'airbnb',
  parser: 'babel-eslint',
  plugins: [
    'react',
    'import',
  ],
  rules: {
    'max-len': 'off',
    'react/jsx-filename-extension': ['error', { extensions: ['.js', '.jsx'] }],
    'import/first': ['error', { 'absolute-first': false }],
    'import/no-extraneous-dependencies': ['error', { devDependencies: true, optionalDependencies: false, peerDependencies: true }],
    curly: ['error', 'all'],
  },
  env: {
    browser: true,
    jest: true,
  },
  settings: {
    'import/cache:': {
      lifetime: 2,
    },
    'import/resolver': {
      webpack: {
        config: path.join(__dirname, 'webpack.config.dev.js'),
      },
    },
  },
};

!.*
node_modules/
coverage/
junit/
dist/
mobiles/
!node_modules/some-package/

What did you do? Please include the actual source code causing the issue.

Introduce linting error in node_modules/some-package/test.js

const test = 1 // missing semi (also unused const)

What did you expect to happen?

A linting error. When I comment node_modules in .eslintignore it works, but also lints node_modules.

What actually happened? Please include the actual, raw output from ESLint.

eslint .
can't resolve reference #/definitions/basicConfig from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #
Done in 47.24s.

Thanks in advance!

[kaelzhang]

@not-an-aardvark

According to the .gitignore rules

It is not possible to re-include a file if a parent directory of that file is excluded.

node_modules/* only ignores the things inside the directory.

While node_modules/ ignores the directory and everything inside it, then node_modules/some-packages could not be re-included because its parent dir node_modules/ is ignored.

[adrienharnay]

Ok figured it out. It was a mix of @kaelzhang 's solution, and the fact that I have nested node_modules in my project.

!.*
coverage/
junit/
dist/
mobiles/
**/node_modules/*
!**/node_modules/some-package/

did the trick. Thanks to all!