Unexpected indent error inside template string after ESLint bump from 4.3.0 to 4.4.1

Tell us about your environment

• ESLint Version: 4.4.1
• Node Version: 8.3.0
• npm Version: 5.3.0

What parser (default, Babel-ESLint, etc.) are you using? babel-eslint

Please show your full configuration:

Configuration

parser: babel-eslint

extends: airbnb

What did you do? Please include the actual source code causing the issue.

const MyComponent = styled.div`
  margin: 0;
  ${(value) => {
    noop();
    return `
      ${value}
    `;
  }}
`; // ← This line triggers an indent error

What did you expect to happen?

I expected no errors.

If the inline arrow function is transformed so the curly braces are removed, the indent error is gone:

const MyComponent = styled.div`
  ${value => `
    ${value}
  `}
`;

What actually happened? Please include the actual, raw output from ESLint.

Since I updated from ESLint 4.3.0 to 4.4.1, the last line in that template string triggers the indent rule.

   9:1  error  Expected indentation of 2 spaces but found 0  indent

[not-an-aardvark]

But can you tell me specific reason why this kind of change was necessary? I’m not sure enforcing users to change their code like this is really worth it…

The indent rule is supposed to validate your code’s indentation. Previously, it was not doing that in a large number of cases. This was causing a lot of confusion for users, because they were accidentally writing code with incorrect indentation, and expecting the indent rule to catch it. (In fact, when we rewrote the rule, indent bugs accounted for about 15% of our open issues.)

If you’d like to restore the indent behavior from 3.x, you can use the indent-legacy rule. If you’d like to ignore indentation for code like your example, you can use the MemberExpression: off option in the indent rule.

[not-an-aardvark]

Ok, thanks for checking again. I’m going to close this since it doesn’t seem to be an issue with eslint.