`object-shorthand`: add option to warn on explicit return arrows

I think I clicked on the right issue template:

Tell us about your environment

• ESLint Version: 3.9.1
• Node Version: 7
• npm Version: stock 3.x

What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration:

"object-shorthand": "error"

What did you do? Please include the actual source code causing the issue.

const obj = {
  foo: () => {},
  bar: (x, y) => { const something = foo(); return something(bar); },
};

What did you expect to happen? The rule to prefer:

const obj = {
  foo() {},
  bar(x, y) { const something = foo(); return something(bar); },
};

What actually happened? Please include the actual, raw output from ESLint. No warning.

Basically, I’d like to add an option to object-shorthand that prefers concise (named) methods over explicit-return arrow functions.

[btmills]

Just added the third 👍, marking as accepted!

[not-an-aardvark]

Just to make sure we’re on the same page, the rule isn’t checking for the presence of return, it’s checking for a BlockStatement as the arrow function body.

So this would also get reported:

var x = {
  foo: () => {
    bar();
    // no return statement
  }
};

But this would not get reported:

var x = {
  foo: () => bar() // body is a CallExpression instead of a BlockStatement
};