prefer-destructuring and reassignment of variables

For example, we have code like:

let error;

if (data.detail) {
    if (data.detail.error) {
        error = data.detail.error;
    } else {
        doSomething();
        error = data.detail;
    }
} else {
    error = data.error;
}

doSomethingWith(error);

prefer-destructuring rule reports 2 issues for this code. I have no ideas how to beautifully refactor this code for following this rule, only renaming a variable and it does not look like a good solution.

So I propose to add an option for reporting about it only for variable declarations, not for assignment expressions.

[fasttime]

Maybe the documentation for this new rule could use some more examples, but in this case, all it really takes to apply destructuring are parentheses:

let error;

if (data.detail) {
    if (data.detail.error) {
        ({ error } = data.detail);
    } else {
        doSomething();
        error = data.detail;
    }
} else {
    ({ error } = data);
}

doSomethingWith(error);

[not-an-aardvark]

Seems like a good idea to me. 👍

Maybe we could have two separate options (one for variable declarations and one for assignment expressions):

prefer-destructuring: [error, {VariableDeclarator: true, AssignmentExpression: true}] # current behavior
prefer-destructuring: [error, {VariableDeclarator: true, AssignmentExpression: false}] # only check declarations
# ... etc