prefer-destructuring proposes object destructuring for array

• ESLint Version: 3.13.0
• Node Version: 7.4.0
• npm Version: 4.0.5

What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration:

'prefer-destructuring': [2, { array: true, object: true }, { enforceForRenamedProperties: true }]

What did you do? Please include the actual source code causing the issue.

/******************************************************************************/
'use strict';
/******************************************************************************/
const arr = ['a', 'b', 'c'];
const last = arr[arr.length - 1];
console.log(last);

What did you expect to happen? No error report.

What actually happened? Please include the actual, raw output from ESLint.

5:7  error  Use object destructuring  prefer-destructuring

The same with this code (that seems to contradict ‘Examples of correct code for this rule’ in the doc).

/******************************************************************************/
'use strict';
/******************************************************************************/
const arr = ['a', 'b', 'c'];
const lastIndex = arr.length - 1;
const last = arr[lastIndex];
console.log(last);

6:7  error  Use object destructuring  prefer-destructuring

[fasttime]

I believe in the first snippet, the line

const last = arr[arr.length - 1];

can be written as

const { [arr.length - 1]: last } = arr;

And in the second snippet

const last = arr[lastIndex];

is the same as

const { [lastIndex]: last } = arr;

[kaicataldo]

I honestly agree that enforcing destructuring with the computed property is confusing and not very easy to read. I would support an option to relax this rule for computed properties. Maybe enforceForComputedProperties, to be in line with the current schema?

{
  "rules": {
    "prefer-destructuring": ["error", {
      "array": true,
      "object": true
    }, {
      "enforceForRenamedProperties": false,
      "enforceForComputedProperties": false
    }]
  }
}