prefer-destructuring reports false positives with compound assignments

Tell us about your environment

• ESLint Version: 3.13.0
• Node Version: 7.3.0
• npm Version: 4.0.5

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

{ "parserOptions": { "ecmaVersion": 6 } }

What did you do? Please include the actual source code causing the issue.

/* eslint prefer-destructuring: error */

let foo = 0;
foo += bar.foo;

What did you expect to happen?

No error, I guess.

What actually happened? Please include the actual, raw output from ESLint.

  4:1  error  Use object destructuring                  prefer-destructuring

[thealjey]

@kaicataldo I personally am not that big on helping people 😃 Creating and properly writing an issue just seems like too much work, sorry 😊

And my suggestion is already out there, it’s pretty simple. It goes like this:

This rule should completely ignore everything but variable definitions (var, const, let, function arguments, commonjs imports) and ignore things that are already a destructuring assignment.

That’s it, at least I cannot think of any other valid use for this rule.

[not-an-aardvark]

I can reproduce this, thanks for the report.

It’s happening because the rule is treating the line the same as

let foo = bar.foo;

…which could be fixed to

let {foo} = bar;