question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BlockchainTests format changed

See original GitHub issue

With https://github.com/ethereum/tests/commit/f386934ce509fa0a4dbd1c68421b3361b01b2efa (and the corresponding deletion https://github.com/ethereum/tests/commit/f11c47462ffc48203b8b588ab35e9ccb3cc79e04#diff-1a427fc3f925eef4e65fb0650dc712f7 ) the format of the transactions in BlockchainTests changed, from signed to unsigned.

Was this breaking change was intended? It has rendered both https://github.com/kframework/evm-semantics and https://github.com/dapphub/dapptools/tree/master/src/hevm incapable of running these tests.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:46 (20 by maintainers)

github_iconTop GitHub Comments

2reactions
FrankSzendzielarzcommented, Sep 18, 2019

Yes unmarshalling from JSON is usually automated based on some strong type, and it’s not always easy to declare a field as something abstract over both string and array type. The existing unmarshaller (deserialiser) in Hive was expecting a target type of array. The fix for me was to ignore the field as it is irrelevant for Hive, but I don’t know if that is always the case for others. I think yes there should be a consistent type. Perhaps add a NEW field to represent the case that the poststate is a hash, while omitting the existing array, so deserialisers can allow for the existing field to be declared as optional.

A stable master should be made available agreed.

1reaction
winsvegacommented, Sep 25, 2019

Going to fix. BCGeneralStateTests already fixed.

Read more comments on GitHub >

github_iconTop Results From Across the Web

ethereum/tests - Gitter
ERROR:/tests/BlockchainTests/ValidBlocks/bcExploitTest/ShanghaiLove.json ... time being and focus on fixing the changed test formats and clean up our code.
Read more >
Blockchain Tests Source Code
Blockchain tests can include multiple blocks and each of those blocks can include multiple ... You can write tests either in JSON format...
Read more >
Blockchain Tests Come to Wall Street - Business Insider
These blockchain tests are yet another sign that we've entered the most profound era of change for financial services companies since the ...
Read more >
Performance Comparison Results of Blockchain tests
To run it, simply do a java -jar PantherChain.jar. It also supports command line parameters to change the difficulty setting, number of repeats, ......
Read more >
R3 Bank Partner Northern Trust Details Four Internal ...
R3 Bank Partner Northern Trust Details Four Internal Blockchain Tests ... Industry-level change, on the other-hand, he says, won't likely ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found