question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tests for 1559 extended requirements

See original GitHub issue

I don’t know where to put these, if we want to just place them in the same location as the random-tests, or somehow make a filler for them, so for now I’ll just open a ticket and we can see where to go from here.

These two tests checks the two necessary preconditions for transaction validity in EIP-1559

1559_MaxFeePerGasExceedsBalance.json:

{
  "MaxFeePerGasExceedsBalance": {
    "_info": {
      "comment": "This test checks the precondition in 1559: assert sender.balance >= gasLimit * transaction.max_fee_per_gas"
    },
    "env": {
      "currentCoinbase": "b94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "currentDifficulty": "0x20000",
      "currentGasLimit": "0x26e1f476fe1e22",
      "currentNumber": "0x1",
      "currentTimestamp": "0x3e8",
      "currentBaseFee": "0x100",
      "previousHash": "0x0000000000000000000000000000000000000000000000000000000000000000"
    },
    "pre": {
      "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0xffffffff",
        "nonce": "0x0"
      },
      "b94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0x0",
        "nonce": "0x1"
      }
    },
    "transaction": {
      "nonce": "0x0",
      "maxFeePerGas": "0x40000",
      "maxPriorityFeePerGas": "0x200",
      "to": "0x0000000000000000000000000000000000000000",
      "data": [
        "0x"
      ],
      "gasLimit": [
        "0x7530"
      ],
      "value": [
        "0x"
      ],
      "secretKey": "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
    },
    "out": "0x",
    "post": {
      "London": [
        {
          "hash": "4adfca7562e66619510a77ea7ea0fb3bef014c9053429fa99a15c8d0132d1789",
          "logs": "1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
          "indexes": {
            "data": 0,
            "gas": 0,
            "value": 0
          }
        }
      ]
    }
  }
}

and 1559_MaxPriorityFeePerGasExceedsMaxFeePerGas.json:

{
  "MaxPriorityFeePerGasExceedsMaxFeePerGas": {
    "_info": {
      "comment": "This test checks the precondition in 1559: assert transaction.max_fee_per_gas >= transaction.max_priority_fee_per_gas"
    },
    "env": {
      "currentCoinbase": "b94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "currentDifficulty": "0x20000",
      "currentGasLimit": "0x26e1f476fe1e22",
      "currentNumber": "0x1",
      "currentTimestamp": "0x3e8",
      "currentBaseFee": "0x100",
      "previousHash": "0x0000000000000000000000000000000000000000000000000000000000000000"
    },
    "pre": {
      "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0xffffffff",
        "nonce": "0x0"
      },
      "b94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0x0",
        "nonce": "0x1"
      }
    },
    "transaction": {
      "nonce": "0x0",
      "maxFeePerGas": "0x200",
      "maxPriorityFeePerGas": "0x201",
      "to": "0x0000000000000000000000000000000000000000",
      "data": [
        "0x"
      ],
      "gasLimit": [
        "0x7530"
      ],
      "value": [
        "0x"
      ],
      "secretKey": "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
    },
    "out": "0x",
    "post": {
      "London": [
        {
          "hash": "4adfca7562e66619510a77ea7ea0fb3bef014c9053429fa99a15c8d0132d1789",
          "logs": "1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
          "indexes": {
            "data": 0,
            "gas": 0,
            "value": 0
          }
        }
      ]
    }
  }
}

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
holimancommented, Jun 7, 2021

@holiman , sorry I didn’t use your tests, but it was easier for me to just to yml

No worries at all! I just wanted to get the test covered, I don’t care if you use my code or something else entirely. Feel free to close this when it’s covered

0reactions
holimancommented, Jun 10, 2021

@MarekM25 And nethermind also is in sync with geth:

./bins/nethtest -i 1559_MaxFee.json 
[
  {
    "name": "MaxFeePerGasExceedsBalance_d0g0v0_",
    "pass": true,
    "fork": "London"
  }
]
Read more comments on GitHub >

github_iconTop Results From Across the Web

ASTM E 1559 Method for Measuring Material Outgassing ...
An analytical laboratory balance is required for pre-test and post-test weighing of material samples. The balance should have a 30 gram or greater...
Read more >
Empirical Analysis of EIP-1559: Transaction Fees, Waiting ...
Our results show that EIP-1559 does not put the blockchain system under a significantly higher load for an extended period than the prior...
Read more >
Recommendation: Cervical Cancer: Screening | United States ...
For women aged 30 to 65 years, the USPSTF recommends screening every 3 years with cervical cytology alone, every 5 years with high-risk ......
Read more >
Draft Guidance Document in support of the Test Guideline on ...
This Guidance Document has been developed to support the use of the OECD Test Guideline (TG) 443 for an Extended One Generation Reproductive...
Read more >
Systems Software Specialist 2 & 3 Series - CA.gov
Agency Code: 7500 Class Code: 1373/1558/1367/1559 Exam Code: 8PB67. Opening Date: December 21, 2009. Closing Date: December 29, 2017.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found