question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[$250] [Feature] RNW Image: Add support for http properties in source

See original GitHub issue

Problem:

Adding headers to images works in React native, but when this gets converted to Web & Desktop code (via react-native-web) it doesn’t work - see https://github.com/necolas/react-native-web/issues/1019

Solution:

Fix this, since we’re planning to start sending encryptedAuthToken in chat report image requests via header!

cc @kidroca since you’ve accepted the challenge to take this on.

Issue Analytics

  • State:open
  • Created 10 months ago
  • Comments:35 (27 by maintainers)

github_iconTop GitHub Comments

3reactions
Beamanatorcommented, Nov 14, 2022

So @kidroca it seems like we are going with this step by step plan:

  1. You’re making web & desktop cache images by fixing react-native-web (this issue)
  2. @thomas-coldwell is upgrading iOS (& maybe Android) caching via react-native-fast-image (https://github.com/Expensify/App/pull/12648)

Once these are implemented, “caching images should work”. Then we can work on:

  1. Using react-native-fast-image everywhere (which means using fallback prop for Web / Desktop)
  2. Clear out / crush related issues in the image enhancements tracker: https://github.com/Expensify/App/issues/10894
2reactions
Beamanatorcommented, Dec 20, 2022

@kidroca In order to unblock our other image enhancement issues, here’s our new plan:

  1. Work on getting https://github.com/Expensify/react-native-web/pull/8 merged into our fork
  2. Get that update working in our App (which will unblock numerous other issues around image caching)
  3. Open a new issue tracking the upstream PR so when it gets merged, we can pull those changes into our fork

Can you let me know if the fork PR is ready to be tested in App? 🙏

Read more comments on GitHub >

github_iconTop Results From Across the Web

Can't get images to work with .Rnw files on RStudio - TeX
It seems that only certain image files break the script. Every graphic that is added to the pdf is created using another R...
Read more >
Customer Portal - Oracle Help Center
The Oracle RightNow Customer Portal Cloud Service (Customer Portal) is your customer support interface. Your customers can search for information, ...
Read more >
S4 Classes for Distributions—a manual for packages "distr ...
These start with package "distrEx", covering statistical functionals like expectation, variance and the median evaluated at distribu- tions, as ...
Read more >
NETSCOUT Arbor Edge Defense (AED)
based, DDoS protection service with over 11 Tbps of mitigation capacity), ... Features. 2600. 2800. Inspected. Throughput. Licenses for 100 Mbps, 250 Mbps, ......
Read more >
TeXShop History - University of Oregon
TeXShop 5.01 came with a demo source file and support document explaining how ... only work when the magnification level of the preview...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found