Follow up: Implement proper fix for android textinput selection workaround

If you haven’t already, check out our contributing guidelines for onboarding and email [e-mail] to request to join our Slack channel!

---

Context

In https://github.com/Expensify/App/pull/11684 there was a workaround introduced. See this conversation for more detail:

https://github.com/Expensify/App/pull/11684/files#r1013587630

It’s about the android TextInput not updating its selection correctly.

Action Performed:

Select a range of text, then call textInput.setSelection(5, 5) on a text selection (for example).

Expected Result:

The android text input selection should just work as it does on web or iOS.

Actual Result:

Under some circumstances, the selection won’t get updated actually on Android.

Workaround:

Already in place

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.25-0 Reproducible in staging?: / Reproducible in production?: / Email or phone of affected tester (no customers): / Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @hannojg Slack conversation: /

View all open jobs on GitHub

[JmillsExpensify]

Here’s my two cents on this issue: I think we should remove the Bug label and instead add the Planning and Weekly labels. The thing is, we already solved the “bug” in the linked issue, and this is effectively a research issue on how to potentially solve Android bugs in the upstream codebase. So yes, I think that’s great, but I also don’t think this is really within the scope of WAQ given that we have something that has resolved the bug for now.

[roryabraham]

No, @hannojg will invoice us separately