[HOLD for payment on July 1] Markdown - Quote markdown behaviour is not correct
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Text should be displayed like this:
- quote indents on subsequent lines should be combined (but separated if there is a blank line between)
- quoting a blank line should be fine
Actual Result:
Text in e.cash is displayed like this:
Action Performed:
- Log in to expensify.cash
- Navigate to a conversation
- Insert this text and press enter
> This is a one line quote
> This is a two line quote
> And this is the second line
> This is a three line quote
>
> With an empty line in the middle that has no space after the chevron
> This is another three line quote
>
> But this time there's a space after the middle chevron
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Web ✔️ iOS Android Desktop App Mobile Web
Version Number: 1.0.35-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Check images above.
Expensify/Expensify Issue URL:
From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1619989048284300
Quote intends are sorta weird; we should copy Slack’s behavior. Here’s the raw text: With an empty line in the middle that has no space after the chevron This is another three line quote
But this time there’s a space after the middle chevron
This is how it comes out (correctly) on Slack, and (incorrectly) on E.cash. In particular:
- quote indents on subsequent lines should be combined (but separated if there is a blank line between)
- quoting a blank line should be fine
Issue Analytics
- State:
- Created 2 years ago
- Comments:27 (22 by maintainers)
Top GitHub Comments
Job paid and closed in Upwork!
@stephanieelliott I’m OOO til 5 July, so am reassigning my chores. Thanks.