[IOU] Users are able to send payment requests and split bills with Concierge

If you haven’t already, check out our contributing guidelines for onboarding and email [e-mail] to request to join our Slack channel!

---

Platform - version:

All platforms - v1.0.37-0

How to enable the Request Money or Spilt Bills flow As the feature is currently behind a beta, you must perform the following change to reproduce the issue. Either navigate to Permissions.js, comment out this line and return true – or apply this diff.txt with git apply path/to/diff.txt

Action Performed (reproducible steps): 0. Read the above section to ensure that the beta feature is available to you

1. Click the + icon on global create and select Request Money or Spilt Bills
2. Enter an amount and click Next
3. Search for [e-mail]
4. Observe that Concierge is listed as a participant and available to send a payment request to
5. Now navigate to the Concierge DM and click the + icon within the DM
6. Observe that Request Money is an available option in the CreateMenu along with Add Attachment

Expected Result:

1. Concierge should not be an available participant to select on the IOUParticipants page via the Request Money or Split Bills flows.
2. Request Money should not be an available option in the CreateMenu when launched from within the Concierge DM

Actual Result:

1. Users can select Concierge as a participant
2. Users can launch the Request Money flow from within the Concierge DM

Notes/Photos/Videos:

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/162867 Upwork Job URL: https://www.upwork.com/jobs/~010daa7b8e343f79e4

View all open jobs on Upwork

[tugbadogan]

That’s right! I missed that we skip participant selection if IOU modal is launched within a chat. In addition to my proposal, we can do the following steps;

• As @Luke9389 recommended, we can check if currently viewed report has concierge as a participant to decide if we need to show IOU menu item here. https://github.com/Expensify/Expensify.cash/blob/b05d83678eecbde2e94e322e26e8ab2c448d58ad/src/pages/home/report/ReportActionCompose.js#L336
• We can throw an exception in createIOUTransaction and createIOUSplit if concierge is somehow passed as a participant, so these requests do not reach to the server even if something is broken on the front end. If you can fix the server side, this step may not be necessary. https://github.com/Expensify/Expensify.cash/blob/7d0987a4d0f96f200005219424ed2b05bf8c88e9/src/libs/actions/IOU.js#L63

[tugbadogan]

Thanks for reverting the PR to resolve the issue, I will send a new PR with including the fix to the regression.