question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When to switch on / off online mode for enrichers ?

See original GitHub issue

I did a refactoring of the GitEnricher since he constantly throws errors because trying to contact a running Kubernetes Cluster.

IMO the default should be offline, which could be switched on by a CD. The reason is, that enriching the resource descriptors with service urls coming from random clusters where one is currently logged in, and which end up in an jar-artefact, too, is not really good for versioning and reproducability (you can’t recreate an artefact later if you are not running in the very same environment).

It’s ok when running in a CD in order to store meta data about the current build because this artefact gets pushed around the pipeline (even then, one need to give up the dream that a single GIt tag is enough to reproducably recreate a piece of software).

So my idea is to start in offline mode and let the CD switch it on with a property. This is currently possible by adding a -Dfabric8.online to the build scripts (if #156 gets merged in). Of course this can be set within the pom.xml, too for a permanent setting.

I introduced an AbstractLiveEnricher which does all the on / offline handling and is supposed to be the single entry point for contacting a cluster.

I also renamed the GitEnricher to a BuildEnricher (since it adds also Jenkins meta data).

Is this ok that we start offline by default ? This also avoids nasty errors and pauses when people start from scratch.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:1
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
rhusscommented, Jul 26, 2016

@rawlingsj Yeah, but isn’t BUILD_ID set for any Jenkins environment, whether it is running in Kubernetes or not ? The problem is, when running online then the enricher tries to detect the Service URL for Gogs (also a fabric8 special thing) and Jenkins.

What I really look for is an env which is specific to our CD which runs on top of Kubernetes (so that one can be somewhat sure that service lookup succeeds)

0reactions
rhusscommented, Oct 5, 2018

Yes, I think we have moved that already out to the deprecated enrichers. Let’s close this issue for now.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Switching Between Online and Offline Mode
To switch between modes: Open the control center. The current state (online or offline) is displayed in the bottom left corner. Click on...
Read more >
Telerik Web Forms Overview - RadSwitch - Documentation
WebForms Switch Overview. The RadSwitch control (Figure 1) enriches the features, that ASP.NET Switch control ... The Switch is part of Telerik UI...
Read more >
Widgets overview—ArcGIS Web AppBuilder | Documentation
Off -panel widgets are widgets that are not in a panel. They can be turned on or off and can be added to...
Read more >
Getting Benchmarking Right online course - AACSB
This online hybrid course seeks to provide a good introduction to benchmarking ... It enriches your school's quality assurance competencies and informs your ......
Read more >
ShiftCam SnapGrip Review: MagSafe Enriches ... - PetaPixel
One of the most glaring build quality issues with my testing sample is that the magnet meant to hold the SnapGrip accessories came...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found