Corrupted images

While I load the images in ListView, some of the images I get are corrupted and shown with half-grayish background. (link attached).

While downloading, I am also saving the image to the disk. Below is the way I’m doing it:

` GenericDraweeHierarchyBuilder builder = new GenericDraweeHierarchyBuilder(context.getResources()); builder .setFadeDuration(50) .setProgressBarImage(null) .setPlaceholderImage(R.color.colorPrimaryLightWithMoreAlpha) .setPlaceholderImageScaleType(ScalingUtils.ScaleType.CENTER_CROP);

    GenericDraweeHierarchy hierarchy =builder.build();
    Uri lowResUri= Uri.parse(imageUrl+"_blur");
    Uri highResUri= Uri.parse(imageUrl);
    imageView.setHierarchy(hierarchy);
    ProductImageHelper productImageHelper = new ProductImageHelper();
    Uri uriLocal = productImageHelper.getUriForProductImage(context,productId);
    ImageRequest localImageRequest = ImageRequestBuilder.newBuilderWithSource(uriLocal).setRequestPriority(priority).build();
    ImageRequest hiresImageRequest = ImageRequestBuilder.newBuilderWithSource(highResUri).setResizeOptions(new ResizeOptions((int) context.getResources().getDimension(R.dimen.product_width),(int) context.getResources().getDimension(R.dimen.product_height))).setRequestPriority(priority).build();
    ImageRequest lowResImageRequest = ImageRequestBuilder.newBuilderWithSource(lowResUri).setRequestPriority(priority).build();
    ImageRequest[] requests = { localImageRequest, hiresImageRequest};
    ImagePipeline imagePipeline = Fresco.getImagePipeline();

    DataSource<CloseableReference<CloseableImage>> dataSource =
            imagePipeline.fetchDecodedImage(hiresImageRequest, context.getApplicationContext());
    dataSource.subscribe(new CustomBitmapDataSubscriber(context.getApplicationContext(),productId,highResUri,uriLocal), CallerThreadExecutor.getInstance());

    DraweeController controller = Fresco.newDraweeControllerBuilder()
            .setLowResImageRequest(lowResImageRequest)
            .setFirstAvailableImageRequests(requests)
            .setOldController(imageView.getController())
            .build();
    imageView.setController(controller);

`

in CustomBitmapDataSubscriber, I am removing hiResUri from memory cache and prefetching localuri in memory cache.

[prgomet]

Problem solved! In my case problem was because onBindViewHolder was called before download was completed and i was checking only if file exists and because of that Fresco loads corrupted image (file is created when download starts), for me solution was to check in database if download was completed.

[foghina]

@triple-dot any chance you’re doing a similar thing to @prgomet?