How to use ImagePipeline.isInDiskCache(uri) in DraweeHolder

In our app we use custom views to show Images. Everything works fine, but when I tried to use ImagePipeline.isInDiskCache(uri) wrong images started to set in wrong places. I use DraweeHolder to show the images. Here is my code:

public void draw(Canvas canvas) {
        Drawable drawable = draweeHolder.getTopLevelDrawable();
        drawable.setBounds(0, 0, width, height);
        drawable.draw(canvas);
    }
private void checkImageCache(String imgUrl, String thumbUrl) {
        ImagePipeline imagePipeline = Fresco.getImagePipeline();
        Uri uri = Uri.parse(imgUrl);

        DataSource<Boolean> inDiskCacheSource = imagePipeline.isInDiskCache(uri);
        DataSubscriber<Boolean> subscriber = new BaseDataSubscriber<Boolean>() {
            @Override
            protected void onNewResultImpl(DataSource<Boolean> dataSource) {
                if (!dataSource.isFinished()) {
                    return;
                }
                boolean isInCache = dataSource.getResult();
                if (isInCache) {
                    loadImage(imgUrl, finalThumbUrl);
                } else {
                    if (isAutoDownloadAllowed()) {
                        loadImage(imgUrl, thumbUrl);
                        draweeHolder.getHierarchy().setProgressBarImage(new CircleProgressBarDrawable());
                    } else {
                        loadThumb(thumbUrl);
                    }
                }
            }

            @Override
            protected void onFailureImpl(DataSource<Boolean> dataSource) {
                Log.d(TAG, "onFailureImpl: " + dataSource.getFailureCause());
            }
        };

        boolean inMemoryCache = imagePipeline.isInBitmapMemoryCache(uri);

        if (inMemoryCache) {
            loadImage(imgUrl, thumbUrl);
        } else {
            inDiskCacheSource.subscribe(subscriber, Runnable::run);
        }
    }

    private void loadImage(String imageUrl, String thumbUrl) {
        
        ControllerListener<ImageInfo> controllerListener = new BaseControllerListener<ImageInfo>() {
            @Override
            public void onFinalImageSet(String id, ImageInfo imageInfo, Animatable animatable) {
                parent.invalidate();
            }

            @Override
            public void onFailure(String id, Throwable throwable) {
                parent.invalidate();
                loadThumb(thumbUrl);
            }
        };

        PipelineDraweeControllerBuilder controllerBuilder = Fresco.newDraweeControllerBuilder()
                .setControllerListener(controllerListener)
                .setOldController(draweeHolder.getController())
                .setAutoPlayAnimations(true)
                .setImageRequest(ImageRequest.fromUri(imageUrl));

        draweeHolder.setController(controllerBuilder.build());
    }

    private void loadThumb(String thumbUrl) {
        ControllerListener<ImageInfo> controllerListener = new BaseControllerListener<ImageInfo>() {
            @Override
            public void onFinalImageSet(String id, ImageInfo imageInfo, Animatable animatable) {
                parent.invalidate();
            }

            @Override
            public void onFailure(String id, Throwable throwable) {
                parent.invalidate();
            }
        };

        DraweeController controllerBuilder = Fresco.newDraweeControllerBuilder()
                .setImageRequest(MediaHelper.getGifThumbnailRequest(thumbUrl))
                .setControllerListener(controllerListener)
                .setOldController(draweeHolder.getController())
                .build();

        draweeHolder.setController(controllerBuilder);
    }

[eldk]

Hello,

If pictures are ordered, maybe you should use one ordered check and not an async one :

https://github.com/facebook/fresco/issues/603

This should slowered the cache check but gives pictures in right order.

Eric

[rafaelekol]

@oprisnik Thank you, I will look into that direction.