0.52.0-rc.0: Yoga Value Conversion Issue preventing build

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Steps to Reproduce

(Write your steps here:)

1. Try to build app in xCode
2. Receive Error Implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int') line 208 in YGNodePrint.cpp const uint32_t childCount = node->children.size();

Not sure if this is related but Line 201 and 293 of Yoga.cpp are also throwing logic errors of Null pointer argument in call to memory copy function

Expected Behavior

I expected my app to work. It had hung up at the splash screen with no errors except the yoga logic errors and I assumed the newer version would resolve them.

Actual Behavior

The app is unable to build due to the yoga issue and xCodes says there are two other logic errors in Yoga.

Reproducible Demo

I would imagine this would just show up in any new project; however, any suggested steps to resolve it would be appreciated.

[dluksza]

In my case, I also need to disable GCC_WARN_64_TO_32_BIT_CONVERSION for yoga and now my project compiles and runs perfectly.

The full workaround for this issue if you are using cocoapods:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'yoga'
            target.build_configurations.each do |config|
                config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
                config.build_settings['GCC_WARN_64_TO_32_BIT_CONVERSION'] = 'NO'
            end
        end
    end
end

[gabrielbull]

Version 0.52.0 was released with this bug still present. I bet there’s going to be an influx of people having this issue now. We really should have resolved this issue before releasing 0.52.0 😬.