Single Dockerfile for both Faucet and Gauge

Currently we use different Dockerfiles for Faucet and Gauge with 2 specific differences - EXPOSE ports and CMD.

In this proposal, I suggest we use a start script for CMD - say faucet. This script can be something like:

#!/bin/bash
case $1 in
    "faucet") python3 faucet --ofp-tcp-listen-port=6653 ...
     ;;
    "gauge") python3 gauge --ofp-tcp-listen-port=6654 ...
    ;;
   *) echo "$0 [faucet|gauge|check-faucet-config]"
esac

If faucet container is started with --volumes, then, for gauge we can use --volumes-from=faucet so that same directories can be loaded.

With the above method, we are building only one image as compared to 2. On the disk, we store only one image.

[gizmoguy]

We should move to docker buildx for our docker image builds which will allow us to build images in multiple archs which will let us remove the various docker-compose-pi.yaml files we have in our repo.

[shivarammysore]

Sounds like a good plan.

On Sep 11, 2019, at 6:36 PM, Brad Cowie [e-mail] wrote:

Okay I understand now with that example from OVS.

I think I’m still against this option as it would require us changing documentation and would break the commands people already run to start faucet and gauge.

I will leave this ticket open to track implementing my solution (use same base image for faucet/gauge dockers), I can’t currently implement it as our docker build CI isn’t smart enough to support dependency ordering, but the new one we’ll be switching to (#3230) will let us do this easily.

Thanks for the suggestion!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.