question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement a better animation when "committing" a new selection range

See original GitHub issue

After #422 is fixed we display the current preselection range besides the already-committed selection ranges at the top. But the animation when we moves from “preselection” to “selection” could be made better, as it’s still the same as we had before the change. It would be better if the “preselected” value would transform seamlessly into the “commited” range.

STR:

  1. Open a profile (for example https://perf-html.io/public/280e10708c0660695ef5af145c53179d29d9796c/calltree/)
  2. Select a range.
  3. Press the “+” button to commit the range

=> the animation at the top should be better.

As a suggestion, here is a possible simple transition:

  • transition the color to the target color
  • transition the opacity of the “>” element from transparent to opaque

This is only about the “appear” transition, as the “disappear” transition is good.

We use react-transition-group to manage transitions already, so hopefully this should be a matter of tweaking CSS classes. The relevant code that defines these transitions is: https://github.com/devtools-html/perf.html/blob/2f5bbfaa23337782ec7e4c468930041f8e453b6b/src/components/shared/FilterNavigatorBar.js#L32-L82 and the relevant CSS is: https://github.com/devtools-html/perf.html/blob/2f5bbfaa23337782ec7e4c468930041f8e453b6b/src/components/shared/FilterNavigatorBar.css#L109-L132

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
canovacommented, Oct 19, 2020

Hi @mariehposa, assigning this to you. Let us know if you need anything!

1reaction
julienwcommented, Oct 17, 2018

Hey @hashi93, as you see, this issue is labeled as “assigned”, this means it’s not available for takers because somebody is already working on it. But you can find some good first issues with this link. And feel free to come on Slack if you have questions!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to use the range selector in After Effects - YouTube
Let's take a look at the range selector and how we can make some slick text animations WITHOUT presets!Music for intro provided by ......
Read more >
Custom Animations in Xamarin.Forms - Microsoft Learn
Running an animation created with the Animation class, which may or may not include child animations, is achieved by calling the Commit method....
Read more >
Reveal or hide a view using animation - Android Developers
There are three common animations to use when showing or hiding a view. You can use the circular reveal animation, a crossfade animation,...
Read more >
Making Connections through Animations | GE Digital
The Animations dialog box expands. Enter a data source to animate the rectangle's height. From the Data Conversion list box, select Range.
Read more >
Use dynamic text—ArcGIS Pro | Documentation
Dynamic text changes based on the current camera, map time, or map range ... Selection is an important part of editing an overlay...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found