The marker table's context menu should propose to copy the marker name

Currently the only way to copy a marker’s name is selecting the row and pressing ctrl+C. It should be in the context menu too.

You could use https://perfht.ml/2wRgEZg as a test.

The code for the context menu is in https://github.com/devtools-html/perf.html/blob/master/src/components/marker-table/ContextMenu.js.

This is the code we use to copy in the treeview: https://github.com/devtools-html/perf.html/blob/da5a48869c5175edc7ddf76c44792115b5c54151/src/components/shared/CallNodeContextMenu.js#L12 We use the npm module copy-to-clipboard and we can do the same thing here.

[julienw]

First I realize the commit had an extra file by mistake. I fixed it and here you can find the good version: https://github.com/devtools-html/perf.html/compare/master...julienw:simplify-marker-context-menu

Now on github it’s possible to get a patch for any diff view by adding .patch to the URL, so in this case this is: https://github.com/devtools-html/perf.html/compare/master...julienw:simplify-marker-context-menu.patch

You can save this patch locally and apply it using 2 different methods:

• git apply FILE.Patch or git apply -3 FILE.patch
• patch -p1 --merge < FILE.patch

This should apply cleanly so you shouldn’t have any conflict.

Hope this helps!

[julienw]

You can start by applying this patch: https://github.com/devtools-html/perf.html/commit/bd2db47f49b0ef50b1246929b96ccf1d5e36d245 This simplifies the logic in the context menu a bit so that it’s easier to work with.

If you’re interested, other issues happening in the same area of code include:

• https://github.com/devtools-html/perf.html/issues/770
• https://github.com/devtools-html/perf.html/issues/1277