Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Percentage values in call tree

See original GitHub issue

While checking out a few profiles, I got confused with the percentage values and thought the algorithm isn’t correct as the total values differed so much. After a closer look, it made sense, but I can imagine other users might run into that issue.

In that context, the 0% values felt also a bit confusing. Is there a reason why we do not display the percentage values with 1 or 2 digits after the comma?

Following are some examples: profile 1

profile 2

Edit: I saw this comment about self percentage values and this one contains the digits after the comma: https://github.com/devtools-html/perf.html/issues/935#issue-314442094

Issue Analytics

State:
Created 5 years ago
Comments:16 (16 by maintainers)

Top GitHub Comments

9reactions

zoepagecommented, Jul 13, 2018

Cool! 😃

How about a vote for which consistent behavior we want @past @gregtatum @mstange @canaltinova @julienw ? 👍 display no digits after 🎉 display 1 digit after ❤️ display 2 digits after

2reactions

julienwcommented, Jun 27, 2018

Note that for your profile 2, I don’t think a digit would actually make a difference. But I don’t know why we decide to display 0 or 1 digits for the percentage values based on the interval value, I don’t think this makes sense.