Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
mergeCallNode does not collapse matching sibling stacks
See original GitHub issueI was reading mergeCallNode and I think I found something that could be argued to be a bug.
If your stack tree looks like this:
- (root)
- frame-to-merge
- frame-to-collapse
- frame-to-collapse
and you merge the call node frame-to-merge into its caller, then you’ll end up with the following tree in your stackTable:
- (root)
- frame-to-collapse
- frame-to-collapse
The two sibling nodes will end up being collapsed in the call node table, once the call node table is computed, but they aren’t collapsed in the stackTable. This is currently not observable in the UI but it might become observable in the future.
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I’ve read this again and still agree with the conclusion: Not having sibling stacks with the same frame is not a property we rely on, and if we had such a guarantee, it wouldn’t unlock any simplifications. So everything’s fine the way it is. Closing.
When we count samples, we loop from the sample table, not the stack table, so I think we won’t fall into this trap.