Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bound values for spin and pulse are not working

See original GitHub issue

Bound values for spin and pulse do not appear to work correctly. Once the spin is turned on, it can never be turned off.

I created a simple use case in the test application:

{{fa-icon 'sync' spin=isSpinning}} {{input type="checkbox" checked=isSpinning}} Spin it

When you set isSpinning to true, the icon correctly begins to spin. But toggling it to false, does not stop the spinning. That is, the fa-spin class is never removed.

https://github.com/tcjr/ember-fontawesome/commit/67aea5ced46894ce7db3756a94753f1788c702b9

Issue Analytics

State:
Created 5 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

4reactions

bgentrycommented, Mar 26, 2018

@robmadole on a related note, one thing that I’ve really liked in other projects is when the readme has a link to an Ember Twiddle that could quickly be forked to set up a bug reproduction. Here’s an example from ember-concurrency. This might help ensure better quality bug reports.

Corresponding readme section here.

1reaction

robmadolecommented, Mar 26, 2018

@tcjr sorry! Mike just pointed out that you have a test case in your fork. My bad. We’ll get this on the list.