Drop support for imported icon object

The syntax:

import Controller from '@ember/controller'
import { faCoffee } from '@fortawesome/fontawesome-free-solid'

export default Controller.extend({
  faCoffee,
});

{{fa-icon faCoffee}}

Is pretty foreign in my ember experience and leads to confusion like #29. I think supporting {{fa-icon 'coffee'}} and

import Controller from '@ember/controller'

export default Controller.extend({
  iconName: 'coffee',
});

{{fa-icon iconName}}

is sufficient, easier to document, and less confusing.

[tcjr]

If not, what advantage is there to having the extra layer of redirection through the controller’s setup of iconName?

It does not need to be there in this case. I believe the main use case for this is being able to set the icon at runtime without putting that logic in the template. Something like this:

  mailIcon: computed('isUnread', () => {
    return this.get('isUnread') ? 'envelope' : 'envelope-open';
  }

and

  {{fa-icon mailIcon}}

[mlwilkerson]

Oh, perfect. That makes sense. Thanks for shedding some light on that, @tcjr.