postgres `IN` query value substitution for lists is incorrect

In [2]: frappe.db.sql("select name from `tabItem` where name in %s", (["abc", "xyz"],), debug=1)
select name from "tabItem" where name in ARRAY['abc','xyz']
Syntax error in query:
select name from "tabItem" where name in %s
---------------------------------------------------------------------------
SyntaxError                               Traceback (most recent call last)
File <ipython-input-2-6d9b73d925f2>:1, in <cell line: 1>()
----> 1 frappe.db.sql("select name from `tabItem` where name in %s", (["abc", "xyz"],), debug=1)

File ~/benches/pg/apps/frappe/frappe/database/postgres/database.py:121, in PostgresDatabase.sql(self, query, values, *args, **kwargs)
    120 def sql(self, query, values=(), *args, **kwargs):
--> 121         return super(PostgresDatabase, self).sql(
    122                 modify_query(query), modify_values(values), *args, **kwargs
    123         )

File ~/benches/pg/apps/frappe/frappe/database/database.py:185, in Database.sql(self, query, values, as_dict, as_list, formatted, debug, ignore_ddl, as_utf8, auto_commit, update, explain, run, pluck)
    182 if not isinstance(values, (dict, tuple, list)):
    183         values = (values,)
--> 185 self._cursor.execute(query, values)
    187 if frappe.flags.in_migrate:
    188         self.log_touched_tables(query, values)

SyntaxError: syntax error at or near "ARRAY"
LINE 1: select name from "tabItem" where name in ARRAY['abc','xyz']
                                                 ^

Hint: List values don’t work but tuple values do.

[phot0n]

(hoping we don’t use it in future as well 📿 🙏 )

[phot0n]

we could cast it to tuple as a quick fix 😛

probably here: https://github.com/frappe/frappe/blob/8c6d266fad4a99103a45125987ff21d260457a3a/frappe/database/postgres/database.py#L405-L430