Make tests stricter for challenge "Decrement a number with javascript"

You can pass the test by assigning 10 to the variable after decrementing it past that value.

It also doesn’t seem like the…

myVar = myVar - 1; should be changed.

…test is not working.

Incorrect code that is passing:

let myVar = 11;

// Only change code below this line
myVar = myVar - 1;
myVar--;
myVar = 10;

Forum: https://forum.freecodecamp.org/t/decrement-a-number-with-javascript-solution/490852

Challenge: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/decrement-a-number-with-javascript

Tests: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/decrement-a-number-with-javascript.md

[lasjorg]

@ShaunSHamilton I don’t think your example is equivalent at all. The end value is supposed to be the result of decrementing, not just assigning a final value.

Yes, I believe that if a user uses the solution that @lasjorg stated, they know how -- works already, which fulfills the objective of the lesson.

Clearly, they do not if they can not decrement the starting value to the final value that is asked for. I see no reason why anyone that understands what the challenge is asking for would do that assignment.

We are not just blindly looking for the -- operator to be used. We are looking for the value 11 to be decremented to 10 using the operator.

An example would be a lesson where you ask someone to use a word in a sentence and they use the word incorrectly. They may have used the word but if it is used incorrectly they do not understand the word. Using it in a sentence means correctly using it, not just blindly shoving it into a sentence.

---

I would think a test with a regex that looks for an assignment to be good enough here.

Do not directly assign the value 10 to the myVar variable.

[import-brain]

1. The second test should be updated. Right now you can leave the initial code even though the test says it should be replaced. It should test that myVar = myVar - 1; is not present in the code.

   1. Check that no assignment is used.

I see, thank you for the clarification!