Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RWD Beta: Test that requires DOCTYPE to be on its own line is failing

See original GitHub issue

Affected page

Several. One example is Learn HTML Forms by Building a Registration Form / Step 2

Your code

<!DOCTYPE html><html></html>

Expected behavior

The hint for this step seems to indicate that the user must add the html element below the DOCTYPE (there must be at least one new line separating them).

Hint: “Your html element should be below the DOCTYPE declaration.:”

So the expected behavior would be that the user will not pass this step until they add the html element below the DOCTYPE.

System

Device: Desktop
OS: Linux/Fedora 34
Browser: Firefox
Version: [e.g. 22]

Additional context

This is happening for several courses. The regex used for this test is not enforcing the newline between the elements. If this requirement is important enough to be enforced then we should probably come up with one regex that enforces this requirement and use it for all courses.

Issue Analytics

State:
Created 2 years ago
Comments:14 (14 by maintainers)

Top GitHub Comments

1reaction

ShaunSHamiltoncommented, Jan 4, 2022

Would you agree with me then that instead of testing for DOCTYPE being on a separate line we should be testing that the DOCTYPE is the first element on the page?

Ideally, yes. As I mentioned below, we do have a solution to the comment thing, but it is a work-in-progress.

https://github.com/freeCodeCamp/freeCodeCamp/pull/44625#issuecomment-1003978797

1reaction

ShaunSHamiltoncommented, Jan 4, 2022

As far as the tests go, I suggest we stick with this:

If the HTML spec can parse it, it is valid, and should be accepted, unless the instructions specifically say, for example, “add a semi-colon at the end of the value”

So, as I can see in the spec, there is no requirement for the DOCTYPE and the html element to be on separate lines: