Remove the buttonSpacer used to add margin between components
See original GitHub issueDescribe the bug We have a component called buttonSpacer and its propose is to add margin between components. We can remove the need for it and use CSS to add the margin.
Usually, I try to think of a reason for it, but the only thing that I can come up with is, this is a relic of the past, and we don’t need it anymore.
If there are special cases in which margin
needs to be added, CSS selectors can handle that. And if it’s there a need for consistency between spacing, adding a gap to its parent component should do the trick, as well.
Here is how it looks without the buttonSpacer, here is the page https://www.freecodecamp.org/settings
With the buttonSpacer
Without the buttonSpacer
Issue Analytics
- State:
- Created 9 months ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Still space between elements (buttons) with "margin: 0"?
The space is caused by the newline and indentation between the two internal divs. Removing the white space will bring the two closer....
Read more >Spacing in CSS - Ahmad Shadeed
A spacer that creates an auto spacing between the header logo and navigation. You might think that making this with CSS is fairly...
Read more >How to Add or Remove Blank Space Between WordPress ...
To remove or add blank space between your blocks, simply click the 'Spacings' option and then scroll down to the 'Margin-Bottom' section. Here ......
Read more >Edit spacing (margin and padding) - PageFly Manual
In this article, you will learn how to control the spacing between elements with margin and padding. This guide you how to edit...
Read more >Spacing - Bootstrap
Assign responsive-friendly margin or padding values to an element or a subset of its sides with shorthand classes. Includes support for individual ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Let me know once you open.
I have did the check, to be honest I don’t want to open it in holiday season, while other maintainers taken time off for holiday @dinesh-14