Step 31 of project "Building a Registration Form" should specify input element must be nested in the label
See original GitHub issueDescribe the Issue
In step 31 of the Learn HTML Forms by Building a Registration Form project, the step doesn’t explicitly say that it wants the input element to be nested inside the label element. Instead it says: “Add a label with the text Upload a profile picture: , and add an input accepting a file upload.” This could be interpreted to mean that the input element should be on the right side of the label element. Only when we attempt this are we told by the Hint “You should nest an input element inside the label element.”
To clarify the requirement, the step should use the word nest in the exercise as below for eg.: “Add a label with the text Upload a profile picture: , and nest an input accepting a file upload within it.”,
Affected Page
Your code
Expected behavior
The step should explicitly state that the input element should be nested within the new label element.
Screenshots
No response
System
Not Applicable
Additional context
No response
Issue Analytics
- State:
- Created 10 months ago
- Reactions:1
- Comments:5 (4 by maintainers)
Top GitHub Comments
I understand that if someone is working on a series of steps they may not need to be told to nest the input again. However, if they stop and return to the project a few weeks later on, they may not remember that. The hint will remind them sure. I guess this is a minor issue given the hint is quite clear. Personally I like a more explicit instruction.
For what it is worth, the camper has nested an input in a label element a few times in this challenge prior to this step.
I am not against adding this reminder to the instructions, but I don’t want to lose sight of our goal to keep the instructions more lean and have the hints serve as the reminders.