Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Setting input boxes use old colours

See original GitHub issue

Describe the bug Some of the input boxes (Email Settings and Your Internet Presence at least) get the old green border when valid inputs are entered.

To Reproduce Steps to reproduce the behavior:

Go to /settings
Scroll down to ‘Your Internet Presence’
Enter https://twitter.com below ‘Twitter’
Click on something else to remove focus
See the green border.

Expected behavior The border should fit with the current colour scheme.

Screenshots SettingsInput

Issue Analytics

State:
Created 4 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

ghostcommented, Oct 17, 2019

Thanks for testing it @ojeytonwilliams 😃

I realized about those two points you mentioned when I was working with this issue, I intended to create several new issues about it and another accessibility issue.

Yes the client validation for email settings and internet presence is all over the place and need some improvements. Border color for focus state on input boxes with night mode is also hard to see. Inverting some colors looks like a good idea.

Now that this issue is already closed, let’s move the discussion to new issues. I will mention you when it have been created.

0reactions

ojeytonwilliamscommented, Oct 17, 2019

@rickysyamsi I tried out your PR and it looks great! Before we go ahead with that I would like your thoughts on a couple of things.

Firstly, are you getting the appropriate error and warning classes applied? Testing locally I don’t seem to be.

Secondly, what do you think about inverting the input boxes in night mode? i.e. dark background + light text to fit in with the rest of the aesthetic.