URL Shortener Microservice needs tests

I’m creating this as a place to discuss how to create tests for this project, so as not to dominate #37185

@ojeytonwilliams For URL Shortener, I need to POST URL (google for example) to shorten it and it should return { "original_url": "www.google.com", "short_url": 1 }. When I access $.get(getUserInput(''url'') + ''/api/shorturl/1''), I should be redirected to google.com.

I will need to either 1) store the original_url as a variable OR 2) POST and then GET in one function. Is there a way to do the first one because that would be cleaner and more readable? And where does the first getUserInput get called from actually?

Here’s an excerpt of my test, second test incomplete:

tests:
  - text: 'It should handle a URL as parameter and return shortened URL'
    testString: 'getUserInput => $.post(getUserInput('url') + '/api/shorturl/new').then(data => assert.exists(data.short_url), xhr => { throw new Error(xhr.responseText)})'
  - text: 'It should handle a shortened URL and redirect to original link'
    testString: 'getUserInput => $.get(getUserInput(''url'') + ''/api/shorturl/3'').then()

[ojeytonwilliams]

Thanks for testing that. So, what I think is that the window object should be off-limits as the potential for creating bizarre and unpredictable bugs is rather high.

Right now we run the tests sequentially, but what about if we decide to run them in parallel to speed things up? After all, waiting for multiple 5 second timeouts is a pain. Suddenly these kinds of tests can fail, more or less at random. Even if we keep the test-runner synced, it makes it hard to maintain as you can’t simply change one test - you might have to change all the dependent tests.

So, while we can do this, I think we’d regret it.

[moT01]

I put a link on the main issue to some examples, or possibly stuff that can just be copy/pasted - looks like whoever made them stores some variables on the window object.