question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make shoulder slope a 'degree' measurement

See original GitHub issue

Implementation to-do

  • Update models package
  • Update neckstimate method in utils
  • Add isDegMeasurement to utils
  • Add support for degree measurement in workbench
  • Port patterns to new shoulderSlope measurement
    • aaron
    • benjamin
    • bent
    • breanna
    • brian
    • bruce
    • carlita
    • carlton
    • cathrin
    • diana
    • florence
    • florent
    • holmes
    • huey
    • hugo
    • jaeger
    • penelope
    • sandy
    • shin
    • simon
    • simone
    • sven
    • tamiko
    • theo
    • titan
    • trayvon
    • wahid
    • waralee

Original issue

With the introduction of Breanna, we changed a bunch of measurements to be better suited to map both the male and female form. We also changed the way we measure shoulder slope, because in practice we noticed that people were routinely measuring this wrong.

I know feel like that was a mistake.

Not that the reasons weren’t legit. People really do get their shoulder slope wrong a lot of the time. But the cure might be worse than the disease. We now measure shoulder slope from down at the hip to the shoulder point. This is a very long measurement, and half a cm (or even a cm) more or less is an easy mistake to make when neither the hip line nor the shoulder point itself are things that are obviously marked on a body.

Yet, a centimeter difference in the shoulder slope measurement makes a huge different. This is very obvious when you sample the shoulder slope measurement in our development environment:

Screenshot_2020-04-11 brian

As you can see, the shoulder slope is now the highly volatile measurement that is even harder to get right. So I’ve made the situation worse.

Let slopes be slopes

I think in the end, it is just simpler to express a shoulder slope in degrees. After all, that’s what it is, a slope. Not a distance.

My first instinct was to not use a shoulder slope measurements anymore, and instead just make it an option with a sensible default that people can adapt. That has the downside that if you know you have sloped shoulders, you’re going to have to set that option manually for each pattern. That’s not great.

The solution to that is store the shoulder slope in the model, just like any other measurement, only this one is in degrees. That would work, but has the downside that now everybody has to measure their shoulder slope again, except now it’s in degrees, how do you even measure that?

Proposal

This is a tricky issue, but I think in the end we need to try and make it harder to have mistakes. So I would suggest to convert the shoulder slope measurement to a degree measurement and give everyone the same (sensible) default. A default that they can adapt if they would like that.

Once that’s done, we’d need to adapt the patterns to use the degrees, but that will make constructing the shoulder a lot simpler.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
AlfaLyrcommented, Apr 14, 2020

Hi again… I come back because I just thought about a very easy way to calculate the angle: you can just take a selfie standing straight, open the photo editor in your phone, go to the straighten option and rotate the photo until one of your shoulders is horizontal. The angle you rotated the photo is your shoulder slope 😃

1reaction
AlfaLyrcommented, Apr 14, 2020

I’m glad you like it 😃 everybody has a protractror around at home to measure angles from a ruler set from school or something, and we can add a drawing explaining how to use it… and whoever can’t be bothered to do that can just have a look at the example drawings

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Determine Degree of Shoulder Slope
Once you've determined your degree of shoulder slope you'll have all the information you need to transfer the information to any sewing pattern....
Read more >
How to Measure Your Shoulder Slope | Video - Threads
What is your shoulder slope, you ask? It is the angle at which your shoulder descends from the side of your neck to...
Read more >
Fitting - Shoulders - In-House Patterns
4. Shoulder Slope: the angle of your shoulder from the base of the neck to the shoulder point. These are the areas you...
Read more >
How to make a shoulder template - thecrookedhem.net
Measure the diameter of the pen that you used to trace the shoulder. I held my pen against a ruler and noted the...
Read more >
How to Measure Your Shoulder Slant - Tznius Tips
Take a protractor and measure the angle created between the horizontal line and the shoulder line at the neck-shoulder point. This angle is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found