git_commit in setup.cfg

@Bultako - Can we get rid of the git_commit key in setup.cfg?

Why not import and use gammapy.version to get the version number, like we do in other places of the docs build?

It’s hard to remember to change the version number there, in addition to setup.py when making a release.

And I’m not sure what’s happening here while I’m trying to make the docs build for the stable version: https://gist.github.com/cdeil/0d504416f43da5df691a5855b42ce325

Did one of these commands change setup.cfg and the git_commit key back to master on disk?

python setup.py build_ext -i
time make docs-all

[Bultako]

Solved in #2212

[cdeil]

@Bultako - as you probably noticed from my comments above, I’m -1 to keep the these versioned binder links coupled to the Sphinx docs build. I think it’s too complex and hard to maintain, and we should focus only on code developments, not configuring and maintaining a cloud service.

I expect that others in CTA will set up a Jupyter cloud service for CTA and install Gammapy there in the near future. When that appears, we can just link to it from http://gammapy.org/ next to the link we have to the Binder we from the Gammapy team set up and maintain at the moment.

@Bultako - Don’t get me wrong. I very much appreciate all the work you have done, and I think having Binder working is a great feature and will be used a lot for tutorials. I just think we should put it more “on the side”, not integrated into our docs build to keep things for Gammapy devs and future release managers as simple as possible.

For me, this is the only remaining open point before finalising #1419 and bringing it for an official vote and resolving it with the Gammapy coordination committee.

@registerrier @adonath @Bultako - Please comment / vote