question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support different map energy binnings in MapMaker

See original GitHub issue

This is a follow-up issue for #1579 and #1580 by @AtreyeeS that weren’t merged.

The question is whether to support different energy binnings for different maps in MapMaker.

Currently all maps (counts, exposure, background) have the same energy binning. The counts and exposure have a reco energy axis, and the exposure has a true energy axis, exposure combined with EDISP is not supported yet. Since #1558 we integrate background in the power-law approximation, using nodes at the energy bin boundaries (this number of nodes option not re-exposed on the Mapmaker, which I think is OK); for exposure we just evaluate at the energy bin centers, the user has no way to control precision except to choose not too large energy bins.

I’m not sure if it will be commonly used, but I’m +1 to add a energy_true=None config argument to MapMaker. By default, energy_true = energy_reco is used and energy_reco is taken from the geom (which defines the counts geom, with a reco energy axis). If the user wants a different energy_true, they can pass a quantity. That’s pretty similar to how the user can choose any energy_true and energy_reco binning they like in gammapy.spectrum.SpectrumExtraction.

@AtreyeeS @registerrier @leajouvin @adonath - Thoughts?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
registerriercommented, Jul 30, 2018

An energy_true vector/axis is clearly needed to create the relevant maps.

Note BTW that a different MapGeom for energy_true could be a valid possibility too. Because of ROI sizes and contamination, one might be forced to model the true sky on a larger space region than the observed one.

Also, for computation efficiency, it is obvious we don’t need to compute reprojected IRFs on a very fine binning (e.g. 0.01°) when the IRF are sampled on a grid 10-50 times less precise. It would be MUCH more efficient to compute exposure and background maps on maps 10 times less precise than the counts maps and at the end of the process interpolate the average map to sample it on the final binning. We might therefore also pass an oversample argument to the MapMaker to compute the reduced IRFs.

0reactions
AtreyeeScommented, Oct 4, 2018

Done in #1846

Read more comments on GitHub >

github_iconTop Results From Across the Web

MapMaker
MapMaker is National Geographic's free, easy-to-use, accessible, interactive, classroom mapping tool designed to amplify student engagement, ...
Read more >
Map Legend Builder Tool | Alteryx Help
The Map Legend Builder tool takes the components output from the Map Legend Splitter Tool and builds them back into a legend table....
Read more >
Cosmic Microwave Background Mapmaking with a Messenger ...
We apply a messenger field method to solve the linear minimum-variance mapmaking equation in the context of. Cosmic Microwave Background (CMB) ...
Read more >
Create and use a binned map—ArcGIS Insights | Documentation
This map visualization is helpful for datasets with a large number of points or densely located points. Example. A municipal water service and...
Read more >
gtbin Help File
energy binning by selecting the binning algorithm type using the "ebinalg" ... Example 2: How to create a count map with different energy...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found