question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FederatedStore should remove from supported operations upon RemoveGraph

See original GitHub issue

Within the FederatedAddGraphHandlerParent there is logic to add Handlers for operations that are unsupported by the FederatedStore, WHEN adding a new graph that DOES support the new operation, which the FederatedStore did not previously support.

This Logic should be explored to confirm that it is still required (in alpha v2)

THEN it likely in RemoveGraph when the LAST graph which supports an operation is removed, it should remove the supported operations from the FederatedStore. (but this part is possibly post v2)

Additional info The handlers which are added this way to support these new operations are just hollow gateway handlers which typically just wrap the operation in a FederatedOperation. Attention should be paid to if the AdminConfiguredMergeMap requires some kind of updating within the FederatedStore constructor. (this part of exploration is possibly post v2)

Issue Analytics

  • State:open
  • Created a year ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
t92549commented, Nov 23, 2022

#2823 is an improvement which will make this less important. However, it still seems like the RemoveGraph should have always changed the supported operations but never did.

0reactions
GCHQDeveloper314commented, Nov 23, 2022

Why is it that option 2 is required at all, now that #2823 has been merged. The way the options were presented appears to be that one choice should be picked and option 3 has been merged, so I’m unsure why this is required and has an active PR?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Issues · gchq/Gaffer - GitHub
FederatedStore should remove from supported operations upon RemoveGraph doc-needed highlight noteworthy item to be added to documentation federated-store.
Read more >
Deprecations - Gaffer Docs - GitHub Pages
This page describes deprecated code which has been removed in Gaffer 2 and how ... (such as Accumulo), all serialisers used on vertices...
Read more >
GovernmentCommunicationsHeadquarters - Bountysource
With the proxy store and federated store I can run a query on one Gaffer graph and write the results into another. When...
Read more >
AllegroGraph 6.1.4 Lisp Reference Guide - Franz Inc.
These functions are used to create, delete, and examine triple-stores. For convenience, many operations act by default on the current ...
Read more >
Federated Car Care
On -time delivery could require longer shipping lead times, so order early! ... Paying for expedited services no longer guarantees on-time delivery.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found