FederatedStore should remove from supported operations upon RemoveGraph
See original GitHub issueWithin the FederatedAddGraphHandlerParent
there is logic to add Handlers for operations that are unsupported by the FederatedStore, WHEN adding a new graph that DOES support the new operation, which the FederatedStore did not previously support.
This Logic should be explored to confirm that it is still required (in alpha v2)
THEN it likely in RemoveGraph
when the LAST graph which supports an operation is removed, it should remove the supported operations from the FederatedStore. (but this part is possibly post v2)
Additional info
The handlers which are added this way to support these new operations are just hollow gateway handlers which typically just wrap the operation in a FederatedOperation
. Attention should be paid to if the AdminConfiguredMergeMap
requires some kind of updating within the FederatedStore constructor. (this part of exploration is possibly post v2)
Issue Analytics
- State:
- Created a year ago
- Comments:6 (6 by maintainers)
Top GitHub Comments
#2823 is an improvement which will make this less important. However, it still seems like the RemoveGraph should have always changed the supported operations but never did.
Why is it that option 2 is required at all, now that #2823 has been merged. The way the options were presented appears to be that one choice should be picked and option 3 has been merged, so I’m unsure why this is required and has an active PR?