question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Are TS type definitions welcome as contribution

See original GitHub issue

As the title says, I am pretty much interested in writing TypeScript definition file(s) .d.ts, but I am a little unsure if the correct place will be the main repository or a separate one, since if they are in the main repo that might come as an additional burden when maintaining (since they also will have to be updated accordingly)

  • as an additional side question, are there any plans for TS in general (rewriting the codebase or anything similar or you are aiming to be strictly JS)

Thanks and keep up the good work 👍

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
DaGhostmancommented, Aug 16, 2018

Sorry for the delay and lack of participation, I was (and unfortunately still am) too occupied with work and can’t find any spare time to look into … well anything. I will try to contribute in some way as soon as I get some spare time on my hands.

Sorry for the downer 😞

1reaction
ichiriaccommented, Nov 28, 2017

I have a small bugfix pending, almost done. Currently it covers 100% of php 7.1 and some pending changes for 7.2.

If it continues like this :

  • v0 was a beta based on jison parser
  • v1 was full rewrite of parser
  • v2 rewrite with a new ast structure

So I’ll keep increasing v2 until I make breaking changes on the API.

So the next major release is not planned, I may either be a breaking change but still on current structure, or introducing a new technology with a major rewrite like passing it on typescript.

Actually I would like to focus on fully covering latest syntax releases of PHP7, try to improve speed, and decrease source size if possible.

I have no time to spend on the project this year, but I should be free and have more time in few month, so next year I would like to work and finish some satellite projects around php-parser and maybe release a functional version of the glayzzle projet 🤞

Read more comments on GitHub >

github_iconTop Results From Across the Web

Serverless service file Typescript definitions will never be ...
The serverless/typescript repository is open-source and all contributions to improve the automatically generated definitions are welcome!
Read more >
Provide typescript definitions · Issue #1 · syntax-tree/mdast-util ...
@crystalfp contributions are welcome, in unified/syntax-tree repos typically the JavaScript is left as is and the typings files are added in their own...
Read more >
TypeScript: JavaScript With Syntax For Types.
TypeScript is JavaScript with syntax for types. TypeScript is a strongly typed programming language that builds on JavaScript, giving you better tooling at...
Read more >
Is there any official Typescript definition for fabric js - Edureka
Typically, packages in Definitely Typed aren't official type definitions. They are user contributed for the better typing of all: ...
Read more >
File: README — AWS SDK for JavaScript
The AWS SDK for JavaScript bundles TypeScript definition files for use in TypeScript projects and ... We welcome community contributions and pull requests....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found