DocBlock identification

DocBlock seem to be identified by the starting /** and following whitespace. This leads to the following edge case (from https://github.com/prettier/prettier-php/issues/30):

/**************
 * test       *
 **************/

is parsed as

{
  "kind": "doc",
  "isDoc": false,
  "lines": [
    "*************\n * test       *\n *************"
  ]
}

and

// a
// b

becomes

{
  "kind": "doc",
  "isDoc": false,
  "lines": [
    "a",
    "b"
  ]
}

Which makes it hard to re-print them the way they were found. Similarly, i can also not tell the difference between /* a */ and // a in the AST.

Maybe it would make sense to change the isDoc flag to just return true whenever /* ... */ syntax is used? Or add another flag?

[ichiriac]

Hi @mgrip,

This will be fixed in the next release. The isDoc was removed, and I’ve introduced 2 new nodes CommentLine or CommentBlock.

I stopped to trim them, so you will have the raw comment node /** foo **/ or # single line comment …

For more details take a look at https://github.com/glayzzle/php-parser/issues/126#issuecomment-370268380

[mgrip]

Thank you! 🙏