_Underscored files are being compiled in v5 rc1
See original GitHub issueUp until version 4, SCSS files starting with an underscore hadn’t been compiled by themselves. v5 rc1 now compiles the corresponding files (in my case .min.css
and .css
) for the partial ones when I save one of them.
Project structure (example)
_basics.scss
style.scss
(importing the _basics.scss in the beginning: @import 'basics';
)
Previous behaviour
Saving _basics.scss
only triggers a save of style.scss
and a compilation of the CSS files for it if it is open (if I am not mistaken), no _basics.css
or _basics.min.css
are created.
Current behaviour
Saving _basics.scss
triggers a compilation of CSS Files for it, e.g. _basics.css
or _basics.min.css
, and triggers errors because the single imported files with underscores only work in tandem with each other when imported into the styles.scss.
Edit: This is the file structure:
-- css\
-- _basics.scss
-- style.scss
-- style.css // Obviously the output file
-- style.min.css // Compressed output file
These are my settings:
"liveSassCompile.settings.formats": [
{
"format": "expanded",
"extensionName": ".css",
"savePath": null
},
{
"format": "compressed",
"extensionName": ".min.css",
"savePath": null
}
],
"liveSassCompile.settings.autoprefix": false,
"liveSassCompile.settings.watchOnLaunch": true,
"liveSassCompile.settings.excludeList": [
".vscode/**",
"wp-admin/**",
"wp-includes/**",
"wp-content/plugins/**",
"wp-content/languages/**",
"wp-content/uploads/**",
"wp-content/upgrade/**"
],
"liveSassCompile.settings.includeItems": [
"wp-content/themes/**/css/*.scss",
"**/wp-content/themes/**/css/*.scss",
],
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (5 by maintainers)
Top GitHub Comments
Thanks, and there’s no rush. I just appreciate the time you’re taking to help out.
I’ll expand my test and see if I can replicate
v5 has had a massive overhaul. Part of that was a transition from the
glob
package to thefdir
package (massive speed boost). It may be thatfdir
behaves slightly different in some way that I haven’t accounted for. Or I’ve made a mistake somewhere in the 1,000 code changes that have been made between v4.4.1 and v5 😁Yeah, as soon as I saw those lines I knew where I’d gone wrong
Thank you. You too