question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking: Consistency across all settings

See original GitHub issue

Nothing here is set in stone. Tagged with help wanted so I can get users thoughts and input

Please keep comments related to this issue. Want something else adding/sorting? Please open a new issue


Bought to light in #22. The new forceBaseDirectory setting is inconsistent with other settings in the extension. Upon reviewing the setting I think it would be handy to force consistency across all settings.

Issue

  • New setting causing confusion as it conflicts with other settings in the extension
    • forceBaseDirectory = "path/to/folder/"
    • Others = "/path/to/folder"
  • Other setting could have better pattern management for:
    • Consistency
    • Help keep the programme running at it’s optimal

Resolution All setting that relate to paths will have the same pattern:

  • A leading slash
  • No ending slash

The includeFiles setting, which relates to files, will have the following restrictions:

  • A leading slash
  • Must end in .sass or .scss

Documentation changes are required

Error detection change
try{ if (!fs.statSync(baseDirectory).isDirectory()) { /*err not folder*/ } } catch { /* err doesn't exist*/ }

Edit: Updated to reflect changes across the settings as a whole (not just the new one in v4.4)

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
szegheocommented, Feb 1, 2021

Should I change all patterns so they must start with a slash but not end with one?

That would be the best (my vote).

0reactions
glenn2223commented, Apr 2, 2021

Fixed in rc2

Read more comments on GitHub >

github_iconTop Results From Across the Web

Can I break consistency in behalf of UX?
Yes. We add consistency to aid the user experience. Consistency is not the ultimate goal, a good experience is.
Read more >
Ongoing E/M overhaul seeks consistency across care settings
Coding and documentation reforms for office and outpatient E/M services instituted in 2021 will be integrated across all health care ...
Read more >
Elementor - using global settings to keep consistency - YouTube
Using consistent colours, fonts and typography across your website is imperative if you want it to look professional.Elementor makes this an ...
Read more >
How to Be Consistent and Why It's Important to Your Success
Consistency requires a long-term commitment from you and involves sustained effort in doing actions repeatedly until you achieve your goals.
Read more >
The Value of Configuration Consistency - Geek Speak
Basically, having a consistent revision of code running means that you have a consistent platform on which to make changes.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found