Placeholder issue for new Pipeline Group SPA

Issue Type

• Bug Report

Summary

Placeholder issue for new Pipeline Group SPA

• When group admin tries to delete a pipeline group, GET calls are made to endpoints api/admin/security/roles and api/users which returns 403 response. This causes generic error (Failed to retrieve pipelines) shown to user. User need to refresh the page to load the pipeline groups.

• Pipeline group permissions create/edit failure messages are not shown completely. Say an admin user tried to update the pipeline group permissions. But provides a non existing role name. On save the API returns appropriate errors Role <some_role> does not exists. But UI shows just a generic error message as Validations failed for pipelines 'GROUP1'. Error(s): [Validation failed.]. Please correct and resubmit.

[GaneshSPatil]

@kritika-singh3 - IMO, I would go for option 1 instead of updating the API. As this is just for the UI representation(In perspective GoCD authorization, other two permissions does not have any meaning when a user has admin permission on pipeline group)

Wouldn’t this lead to having different representations for the config? An API call says [view, admin] and UI says [view, operate, admin]??

IMO, our SPAs should be dumb, they should just represent whatever the API sends as is!

[bdpiprava]

@kritika-singh3 - IMO, I would go for option 1 instead of updating the API. As this is just for the UI representation(In perspective GoCD authorization, other two permissions does not have any meaning when a user has admin permission on pipeline group)