Unable to run commands with `/bin/bash -c` in v19.12.0

Issue Type

• Bug Report

Summary

GoCD v19.12.0

Steps to Reproduce

Run a job with the following command

              <exec command="/bin/bash">
                <arg>-c</arg>
                <arg>echo $HOME</arg>
                <runif status="passed" />
              </exec>

Expected Results

You should see the current path stored in the $HOME env var.

Actual Results

[go] Task: /bin/bash -ctook: 0.103sexited: 2
 "echo $HOME"
/bin/bash: -
: invalid option
Usage:	/bin/bash [GNU long option] [option] ...
	/bin/bash [GNU long option] [option] script-file ...
GNU long options:
	--debug
	--debugger
	--dump-po-strings
	--dump-strings
	--help
	--init-file
	--login
	--noediting
	--noprofile
	--norc
	--posix
	--rcfile
	--restricted
	--verbose
	--version
Shell options:
	-ilrsD or -c command or -O shopt_option		(invocation only)
	-abefhkmnptuvxBCHP or -o option
[go] Task status: failed, took: 0.103s, exited: 2

[kritika-singh3]

@bsodmike I was able to reproduce the issue. As part of performance improvement to our pipeline config pages we started utilizing the Pipeline Config API to update tasks as part of https://github.com/gocd/gocd/pull/7400 . While updating the config, the task contains a \r in the args which is treated as a newline by the command line. So the config which is saved is

<exec command="/bin/bash">
                <arg>-c\r</arg>
                <arg>echo $HOME</arg>
                <runif status="passed" />
 </exec>

Since \r is a non-printable character, it is not visible on any UI. The logs I asked was to confirm that the command is actually not utilizing the echo part. Hence, the actual command which ran was /bin/bash -c which is an incorrect. Hence the error.

Now, the fix you mentioned was not due to removing the said line. It was because the whole config was overwritten by the arg without \r in it. Thanks for reporting the issue. I will take a deeper look into it later in this week.

[maheshp]

The other workaround is to save the cruise_config.xml without making any changes.

1. Go to https://<gocd_server_url>/go/admin/config_xml
2. Click Edit and Save