Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Excluding all logged in users from Analytics results in invalid JSON in Web Stories preview debug mode

See original GitHub issue

Bug Description

1.) When you enable the option to exclude all logged in users from Analytics in Site Kit by Google, Story passes AMP validator, but Story’s debug mode in the story preview is outputting the below warning Screen Shot 2021-06-11 at 12 06 36 PM

Steps to reproduce

Go to Site Kit settings
Click on edit Analytics > Exclude from Analytics all logged-in users
Go to Web Stories
Open in editor > preview a story
See debug tab and notice invalid JSON error

Screenshots

Additional Context

PHP Version:
OS: [e.g. iOS]
Browser [e.g. chrome, safari] chrome
Plugin Version [e.g. 22] 1.34.0
Device: [e.g. iPhone6] macOS

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The GA opt-out element output for AMP should not raise any validation errors or warnings for HTML or AMP markup validation

Implementation Brief

Merge https://github.com/google/site-kit-wp/pull/3593. See conversation on https://github.com/google/web-stories-wp/issues/7939 issue for more information

Test Coverage

No changes

Visual Regression Changes

QA Brief

Set up and configure Analytics to exclude tracking for logged in users (default)
Enable Web Stories and create a new story
Leave blank and click Preview
On the preview screen, click the Debug tab
Review the results, ensure the __gaOptOutExtension element is not reported (there may be other validation errors/warnings not from Site Kit)

Changelog entry

Fix AMP validation error caused by the GA opt-out snippet conditionally placed by Site Kit.

Issue Analytics

State:
Created 2 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

2reactions

aaemnnosttvcommented, Jun 23, 2021

@wpdarren actually, sorry, it should be good – I just tested this again and while there are errors that show Site Kit, it’s mostly because the output is minified and line 6 starts with our opt-out comment there which is normal. The main error we don’t want to see is the first one in your screenshot there about invalid JSON.

Here’s what I see