question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix SetupSuccessBannerNotification stories.

See original GitHub issue

Bug Description

The Authentication Success stories under SetupSuccessBannerNotification are currently broken and should be fixed.

Steps to reproduce

  1. Open Storybook and go to SetupSuccessBannerNotification.
  2. Click through the Authentication Success stories to see them in a non-functional state.

Screenshots

image

Additional Context

  • PHP Version: any
  • OS: any
  • Browser: any
  • Plugin Version: 1.86.0
  • Device: any

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Authentication Success stories under SetupSuccessBannerNotification should be restored to their working state.
  • VRT scenarios should be added to avoid this happening again.

Implementation Brief

  • Set the googlesitekit_manage_options capability to true by dispatching the receiveGetCapabilities or receiveCapabilities action of the core/user store.
  • Add VRT scenarios for all the authentication_success stories by adding the scenario property to the stories.

Test Coverage

  • No new tests are to be added.
  • VRT scenarios should be added as mentioned in the IB.

QA Brief

  • Verify that all the Storybook stories under SetupSuccessBannerNotification works as expected.

Changelog entry

  • N/A

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5

github_iconTop GitHub Comments

1reaction
tofumattcommented, Oct 26, 2022

ACs are good, thanks for adding a VRT requirement 👍🏻

0reactions
wpdarrencommented, Nov 24, 2022

QA Update: ✅

Verified:

  • All the Storybook stories under SetupSuccessBannerNotification work as expected.
    • Went through each story and clicked the CTA and links, everything looks good.
    • Checked that no console errors occured.
  • Set up a new site and connected all of the modules to ensure that the success banner notifications appeared.

https://user-images.githubusercontent.com/73545194/203735312-c4cb4654-6b03-47cc-aa67-adc6de5d1673.mp4

Read more comments on GitHub >

github_iconTop Results From Across the Web

8 Tips for Designing Inclusive Notifications and Alerts
I have been working on redesigning the notification banner component in our design ... StackExchange informing the user of a critical error.
Read more >
A Comprehensive Guide to Notification Design - Toptal
Notifications are an indispensable part of digital products, but they should never harm the user experience. Proper notification design during the product ...
Read more >
Daltron/NotificationBanner: The easiest way to ... - GitHub
The easiest way to display highly customizable in app notification banners in iOS - GitHub - Daltron/NotificationBanner: The easiest way to display highly ......
Read more >
How do I turn notifications for stories on or off on Facebook?
While you can't turn off Facebook notifications for stories entirely, you can: ... Adjust your notification settings in the Messenger app for stories....
Read more >
What are Push Notifications? A Complete Guide [Up-to-date]
Push notification alerts can be displayed in three locations on your phone—lock screen, banner, and notification center, when the app user opts-in for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found