Update Tooltips styles to match GM2+ designs
See original GitHub issueBug Description
Currently the tooltips look almost like dropdown menus, resulting in an odd user experience.
Screenshots
Tooltip:
Dropdown menu:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- General Site Kit tooltips (e.g. in SK header bar and dashboard sharing modal) should be styled as per the designs in Figma.
Note: TourTooltips should not be affected by changes made to the Tooltip component.
Implementation Brief
- Regression was introduced as part of the changes in #5444
- Using
assets/sass/components/global/_googlesitekit-tooltip.scss
,- Remove/update the styles for
.googlesitekit-tooltip.MuiTooltip-tooltip
and.googlesitekit-tooltip .MuiTooltip-arrow
to match the Tooltip styles we have in the Figma designs, i.e more rounded corners, black background color,etc
- Remove/update the styles for
- All tooltips styles should be consistent which means undoing the work done in #5444
Test Coverage
- No new tests to be added.
QA Brief
- Locate a tooltip (SK header, dashboard sharing, etc)
- Compare the styling of the element and ensure it matches the figma design provided in the AC
- If inspecting using the devtools is necessary, you can force the tooltip to stay open by enabling a breakpoint for attributes on the element triggering the tooltip (see screenshots below)
Screenshots
Locate an element that has a tooltip, here I’m using the dashboard sharing trigger
Right click it and set it to break on attribute modifications
Click the forward arrow to step through the code, until the tooltip appears. It can now be inspected and wont go away until you remove the breakpoint
Changelog entry
- Update Tooltip styles to match GM2+ designs.
Issue Analytics
- State:
- Created a year ago
- Reactions:2
- Comments:9 (3 by maintainers)
Top Results From Across the Web
Tooltips | Charts - Google Developers
Hover over the bars to see standard tooltips. Customizing tooltip content. In this example, we add custom content to the tooltips by adding...
Read more >Tooltips · Bootstrap v5.0
Documentation and examples for adding custom Bootstrap tooltips with CSS and JavaScript using CSS3 for animations and data-bs-attributes for local title ...
Read more >12 (Unbelievably) Good Tooltip Examples and Best Practices
1- Use good colors that stand out ... If I had to pick only three best practices for the best tooltip design, this...
Read more >Customizing tooltips in Power BI Desktop - Microsoft Learn
There are many ways to customize tooltips, using any field available in your dataset, to convey quick information and insights to users viewing ......
Read more >Tooltips: How to create and use the mighty UI pattern - Appcues
Tooltips are powerful when designed well and used strategically. Check out our tips on great tooltip design with a bunch of examples inside!...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@marrrmarrr this is consistent with most other Google web interfaces (e.g. Gmail, Drive, Docs) which have a tooltip for the user menu which also includes the same information. It is redundant but is probably there for accessibility and consistency with other menu buttons. Our implementation is largely mirroring the pattern which is already present across many major Google products 🙂
Closing this out for the release as you’ve noted it isn’t release blocking. Thank you!
@felixarntz I thought we wanted to keep the styles for the dashboard sharing tooltip to match the Figma designs, hence why we had #5444 However, I see your point of having all tooltips to be consistent and match what we have in the designs for Tooltips. I’ve updated the IB, let me know what you think.