question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Full width blue background on GA4 notices

See original GitHub issue

Feature Description

Some Figma screens have the blue bar full width, others have the blue bar at the end of the dropdown, which is correct?

Related Asana task


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The “Learn more” link in the blue notice in the Analytics setup flow (UA, GA4, and GA4-transitional only) should always be aligned to the very right of the notice, even if the screen is very wide.
  • Instead, the blue notice in that flow should have its maximum width limited in a way that prevents the “Learn more” link from appearing too far away / too decoupled from the notice main content. (There is no exact number given, please include @Pratheep-lab in the PR review for this.)

Implementation Brief

Using _googlesitekit-settings-notice.scss update .googlesitekit-settings-notice adding a max-width of 1098px.

Test Coverage

  • n/a

Visual Regression Changes

  • Check visual tests

QA Brief

  • Using storybook and / or the analytics set up flow, verify that the maximum width of the GA4 notice is 1098px

Changelog entry

  • Improve Google Analytics 4 notices.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
wpdarrencommented, Jun 25, 2021

QA Update: ✅

  • Verified that the maximum width of the GA4 notice is 1098px on large screen sizes
  • Also checked the notices on smaller screens to make sure no styling issues exist.

Screenshot 1 - Screenshot 2 - Screenshot 3

1reaction
johnPhillipscommented, Jun 23, 2021

@wpdarren Good catch, thanks. This appears to be a pre-existing issue as when I revert the change the issue is still visible. It might be to do with the dropdown overflowing the container, because the content wraps perfectly when I remove the dropdown from the markup:

Screenshot 2021-06-23 at 16 41 30

I’m very happy to investigate further but am conscious this was estimated as a 3pt 1-liner to address a different problem. @aaemnnosttv Should I investigate under this issue or is it out of scope?

Read more comments on GitHub >

github_iconTop Results From Across the Web

[GA4] Analytics dimensions and metrics - Google Support
This article describes the dimensions and metrics that appear in your reports and explorations and in the audience and segment builders.
Read more >
Google Analytics 4: GA4 Guide to Almost Everything - Webfor
In this guide, we are going to cover a wide range of important reports and features of Google Analytics 4. This guide will...
Read more >
How To Set Up A Google Analytics 4 Property - ERI Design
You will see a map in the background of the dashboard. Find where you are in the world, if you see a pulsating...
Read more >
Prepare now for the switch to Google Analytics 4
With some 15 months' notice, organizations have time to prepare migrations ... prompts Google to create a full property and code using the...
Read more >
Curated GA4 Links - Scott C. Krause
Released in October of 2020, Google Analytics 4 (GA4) will shake up traditional Google Analytics reporting and provide deeper integration ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found