question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Styling of property select in GA4 notice on settings page looks off

See original GitHub issue

Feature Description

Styling of the Property select dropdown is grey instead of blue as per designs.

image

Please see Figma comment here also

Related Asana task

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When displayed within an info notice, any text input field should have similar appearance to the dropdowns, using a blue border etc.

Implementation Brief

  • Update assets/sass/components/settings/_googlesitekit-settings-notice.scss to include the styles for .mdc-text-field similar to what’s being done for .mdc-select

Test Coverage

  • No new tests to be added.

Visual Regression Changes

  • N/A

QA Brief

Note that the fix is for the screenshot on this comment https://github.com/google/site-kit-wp/issues/3541#issuecomment-866716827 NOT the screenshot in the description

  • Have a UA and a GA4 property set up in Analytics for a site
  • Set up Site Kit on site
  • Start Analytics set up
  • select GA4 property
  • Inside Notice component select “set up a new property”
  • should now be in the same state as on the screenshot
  • Observe text input is styled like selects (hover state, selected state, etc)

Changelog entry

  • Update styles of controls in the GA4 notice box on the settings page.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
wpdarrencommented, Jul 6, 2021

QA Update: Pass ✅

  • For a site with UA and a GA4 property set up in Analytics. When you select GA4 property and then ‘Set up new property’ in the notice component, the property, view and view name fields have blue borders, blue text. Can also confirm that the text input is styled appropriately.
  • Checked this also in our primary browsers, i.e. Firefox, Safari, etc.

image

0reactions
felixarntzcommented, Jun 29, 2021

@aaemnnosttv @asvinb Thanks, makes sense. I’ve rephrased the ACs - and the IB already looks good ✅

Read more comments on GitHub >

github_iconTop Results From Across the Web

[UA→GA4] Universal Analytics versus Google Analytics 4 ...
This article explains the differences between the UA and GA4 data models. To understand the differences between specific metrics in UA and GA4...
Read more >
GA4 Problems - 4 Challenges With Google Analytics 4
According to Google, an engaged session is a “session that lasted 10 seconds or longer, or had 1 or more conversion events or...
Read more >
The Google Analytics 4 Tutorial for Beginners 2022
In this Google Analytics 4 tutorial, you'll learn what GA4 is all about and ... From the property settings, click on Data Streams...
Read more >
Google Universal Analytics Is Going Away: What You Need ...
Once you set up GA4, you'll have a “Google Analytics 4 property” for that same website. Because UA and GA4 are different, different...
Read more >
Step-by-Step Guide: Setting Up New Analytics 4 Property
The first thing we will do is create the GA4 property in Google Analytics. ... If you are adding Google Analytics 4 to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found